Skip to content

build: add --shared-perfetto flag - #65614

Merged
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:shared-perfetto-sdk
Sep 7, 2026
Merged

build: add --shared-perfetto flag#65614
aduh95 merged 2 commits into
nodejs:mainfrom
aduh95:shared-perfetto-sdk

Conversation

@aduh95

@aduh95 aduh95 commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Converted to draft, I need to investigate the abseil version conflict

@nodejs-github-bot

nodejs-github-bot commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/actions
  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to Node.js builds or CI infrastructure. dependencies PRs that add, update, or configure Node.js dependencies. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency. labels Aug 28, 2026
@github-actions

This comment was marked as outdated.

Sign in to view
@codecov

codecov Bot commented Aug 28, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.21%. Comparing base (9f7ae86) to head (1d0e5f1).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #65614      +/-   ##
==========================================
+ Coverage   90.19%   90.21%   +0.01%     
==========================================
  Files         771      771              
  Lines      264911   264911              
  Branches    50323    50323              
==========================================
+ Hits       238939   238977      +38     
+ Misses      16922    16917       -5     
+ Partials     9050     9017      -33

see 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
aduh95 marked this pull request as draft August 28, 2026 13:43
@aduh95 aduh95 mentioned this pull request Aug 31, 2026
Merged
@aduh95
aduh95 force-pushed the shared-perfetto-sdk branch 2 times, most recently from a040aae to 0242613 Compare September 4, 2026 13:34
@aduh95
aduh95 marked this pull request as ready for review September 4, 2026 13:34
@github-actions

This comment was marked as outdated.

Sign in to view
@aduh95
aduh95 force-pushed the shared-perfetto-sdk branch from 0a435be to b84cf45 Compare September 4, 2026 14:18
@github-actions

This comment was marked as outdated.

Sign in to view
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 4, 2026
@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76981/

@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2404-intel-64,v8test=v8test/7344/

@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/7344/

@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-power9le,v8test=v8test/7344/

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor
Platform Number of requisites Proportion of new derivations
x86_64-linux 491 -> 496 => +5 5 / 496 = 1.0%
aarch64-linux 492 -> 497 => +5 5 / 497 = 1.0%
x86_64-darwin 431 -> 436 => +5 5 / 436 = 1.1%
aarch64-darwin 434 -> 439 => +5 5 / 439 = 1.1%
Total 1848 -> 1868 => +20 20 / 1868 = 1.0%
Changelog 
@@ -1301,0 +1302,8 @@
+/nix/store/zfisa71cs2rc5qwd7wv89v54gd48knz5-perfetto-sdk-58.2 (aarch64-darwin)
+/nix/store/5gg54qf3b7xk32rshsnamlg0d21imazb-perfetto-sdk-58.2 (aarch64-linux)
+/nix/store/sy3bgw5f9g8g0zwbxns3qknab5ncb8y9-perfetto-sdk-58.2 (x86_64-darwin)
+/nix/store/dy9bqw5rzzcaj7nbspq63gxcvvhd2s4i-perfetto-sdk-58.2 (x86_64-linux)
+/nix/store/riqv60hi34gjsfk8cbvgpm15jcwnx30y-perfetto-sdk-58.2-dev (aarch64-darwin)
+/nix/store/c2hj3vkrjg3vp5gm7cj573afwgnvgn82-perfetto-sdk-58.2-dev (aarch64-linux)
+/nix/store/b74ljrh1z52l01636wblrlgxhajir4ik-perfetto-sdk-58.2-dev (x86_64-darwin)
+/nix/store/k7k45cp5mj2qdrr7h9zkm24549amgjh7-perfetto-sdk-58.2-dev (x86_64-linux)
@@ -1494,0 +1503,4 @@
+/nix/store/dmcp8nf832l2fbhhbac84bq4prrlk1nq-protobuf-34.1 (x86_64-darwin)
+/nix/store/wylvda2p4ab62dzzsgppbclpmh4j2f8r-protobuf-35.1 (aarch64-darwin)
+/nix/store/14zdwpp05sjf7813mcjjzhgl816hjbqj-protobuf-35.1 (aarch64-linux)
+/nix/store/9d8d0spap5fb4d4hkxliag8zlfhjcg67-protobuf-35.1 (x86_64-linux)
@@ -1588,0 +1601,8 @@
+/nix/store/m59bb6fx8i7q9ar970x8y4pqky31z9fi-re2-2025-11-05 (aarch64-darwin)
+/nix/store/q2wb70xl8vf69880ym2pilc9fpp5i7zp-re2-2025-11-05 (aarch64-linux)
+/nix/store/fh849rr6slz7d44xdbi1556ama6g5hvm-re2-2025-11-05 (x86_64-darwin)
+/nix/store/3x5532sa2gihl6gqxmi38vrmax01cwxz-re2-2025-11-05 (x86_64-linux)
+/nix/store/ysvwsxmz1vyv28jnplfk07s6ys6cb013-re2-2025-11-05-dev (aarch64-darwin)
+/nix/store/ywzpib7jl9djfbhvlf8pkd1pbhjcbb46-re2-2025-11-05-dev (aarch64-linux)
+/nix/store/dvzkr8dc8m5lmr4vvkpga60bzgwacq2f-re2-2025-11-05-dev (x86_64-darwin)
+/nix/store/yxak24k0j97addadfrag61qbc97fq5i7-re2-2025-11-05-dev (x86_64-linux)

@nodejs-github-bot

nodejs-github-bot commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/76994/

@nodejs-github-bot

nodejs-github-bot commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/77053/

@aduh95
aduh95 requested a review from legendecas September 6, 2026 13:41
@aduh95
build: add --shared-perfetto flag
073e85d 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#65614
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
tools: add GHA workflow to test vendored Perfetto
1d0e5f1 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#65614
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
aduh95 force-pushed the shared-perfetto-sdk branch from 94a72bd to 1d0e5f1 Compare September 7, 2026 13:24
@aduh95

aduh95 commented Sep 7, 2026

Copy link
Copy Markdown
Contributor Author

Landed in 9f7ae86...1d0e5f1

@aduh95
aduh95 merged commit 1d0e5f1 into nodejs:main Sep 7, 2026
31 checks passed
@aduh95
aduh95 deleted the shared-perfetto-sdk branch September 7, 2026 13:29
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor
Platform Number of requisites Proportion of new derivations
x86_64-linux 496 -> 501 => +5 5 / 501 = 0.9%
aarch64-linux 497 -> 502 => +5 5 / 502 = 0.9%
x86_64-darwin 436 -> 441 => +5 5 / 441 = 1.1%
aarch64-darwin 439 -> 444 => +5 5 / 444 = 1.1%
Total 1868 -> 1888 => +20 20 / 1888 = 1.0%
Changelog 
@@ -1305,0 +1306,8 @@
+/nix/store/zfisa71cs2rc5qwd7wv89v54gd48knz5-perfetto-sdk-58.2 (aarch64-darwin)
+/nix/store/5gg54qf3b7xk32rshsnamlg0d21imazb-perfetto-sdk-58.2 (aarch64-linux)
+/nix/store/sy3bgw5f9g8g0zwbxns3qknab5ncb8y9-perfetto-sdk-58.2 (x86_64-darwin)
+/nix/store/dy9bqw5rzzcaj7nbspq63gxcvvhd2s4i-perfetto-sdk-58.2 (x86_64-linux)
+/nix/store/riqv60hi34gjsfk8cbvgpm15jcwnx30y-perfetto-sdk-58.2-dev (aarch64-darwin)
+/nix/store/c2hj3vkrjg3vp5gm7cj573afwgnvgn82-perfetto-sdk-58.2-dev (aarch64-linux)
+/nix/store/b74ljrh1z52l01636wblrlgxhajir4ik-perfetto-sdk-58.2-dev (x86_64-darwin)
+/nix/store/k7k45cp5mj2qdrr7h9zkm24549amgjh7-perfetto-sdk-58.2-dev (x86_64-linux)
@@ -1498,0 +1507,4 @@
+/nix/store/dmcp8nf832l2fbhhbac84bq4prrlk1nq-protobuf-34.1 (x86_64-darwin)
+/nix/store/wylvda2p4ab62dzzsgppbclpmh4j2f8r-protobuf-35.1 (aarch64-darwin)
+/nix/store/14zdwpp05sjf7813mcjjzhgl816hjbqj-protobuf-35.1 (aarch64-linux)
+/nix/store/9d8d0spap5fb4d4hkxliag8zlfhjcg67-protobuf-35.1 (x86_64-linux)
@@ -1608,0 +1621,8 @@
+/nix/store/m59bb6fx8i7q9ar970x8y4pqky31z9fi-re2-2025-11-05 (aarch64-darwin)
+/nix/store/q2wb70xl8vf69880ym2pilc9fpp5i7zp-re2-2025-11-05 (aarch64-linux)
+/nix/store/fh849rr6slz7d44xdbi1556ama6g5hvm-re2-2025-11-05 (x86_64-darwin)
+/nix/store/3x5532sa2gihl6gqxmi38vrmax01cwxz-re2-2025-11-05 (x86_64-linux)
+/nix/store/ysvwsxmz1vyv28jnplfk07s6ys6cb013-re2-2025-11-05-dev (aarch64-darwin)
+/nix/store/ywzpib7jl9djfbhvlf8pkd1pbhjcbb46-re2-2025-11-05-dev (aarch64-linux)
+/nix/store/dvzkr8dc8m5lmr4vvkpga60bzgwacq2f-re2-2025-11-05-dev (x86_64-darwin)
+/nix/store/yxak24k0j97addadfrag61qbc97fq5i7-re2-2025-11-05-dev (x86_64-linux)

aduh95 added a commit that referenced this pull request Sep 7, 2026
@aduh95
build: add --shared-perfetto flag
313fd1f 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65614
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit that referenced this pull request Sep 7, 2026
@aduh95
tools: add GHA workflow to test vendored Perfetto
0cc8029 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65614
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit that referenced this pull request Sep 7, 2026
@aduh95
build: add --shared-perfetto flag
ec6b06e 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65614
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit that referenced this pull request Sep 7, 2026
@aduh95
tools: add GHA workflow to test vendored Perfetto
b4f5d35 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65614
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions Bot mentioned this pull request Sep 7, 2026
Open
aduh95 added a commit that referenced this pull request Sep 7, 2026
@aduh95
build: add --shared-perfetto flag
6900c30 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65614
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit that referenced this pull request Sep 7, 2026
@aduh95
tools: add GHA workflow to test vendored Perfetto
a22f4bd 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65614
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit that referenced this pull request Sep 7, 2026
@aduh95
build: add --shared-perfetto flag
7c33c4d 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65614
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit that referenced this pull request Sep 7, 2026
@aduh95
tools: add GHA workflow to test vendored Perfetto
08a3fc8 
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #65614
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes
@legendecas legendecas Awaiting requested review from legendecas

Assignees

No one assigned

Labels

build Issues and PRs related to Node.js builds or CI infrastructure. dependencies PRs that add, update, or configure Node.js dependencies. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. meta Issues and PRs related to the general management of the project. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aduh95 @nodejs-github-bot @jasnell